Initial implementation cross platform powershell #83
Conversation
AdaskoTheBeAsT
force-pushed
the
feature/cross-platform
branch
4 times, most recently
from
d13696a to
a9a034e
Compare
|
Build green :) |
AdaskoTheBeAsT
force-pushed
the
feature/cross-platform
branch
from
6604b0b to
0daaab2
Compare
| @@ -4,6 +4,7 @@ init: | |||
|
|
|||
| # Build script | |||
| build_script: | |||
| - cmd: powershell -NoProfile -ExecutionPolicy unrestricted -Command .\appveyor.ps1 | |||
There was a problem hiding this comment.
I've updated the AppVeyor build image to Visual Studio 2019 so .Net 3.1 should now be installed by default. You should be able to drop this command now.
There was a problem hiding this comment.
Ok I updated script and removed unnecessary script - lets see :)
There was a problem hiding this comment.
Unfortunatelly appveyor is not able to find .net core 3.1 for testing purposes
There was a problem hiding this comment.
Hmm, I was going off this update from Appveyor that says .NET Core 3.1.406 is included in the latest Visual Studio 2019 image but its hard to argue with that build log.
There was a problem hiding this comment.
ok I will return back script for now if you don't mind :)
| <group targetFramework=".NETCoreApp3.1"> | ||
| <dependency id="Microsoft.PowerShell.SDK" version="7.0.5" /> | ||
| </group> | ||
| <group targetFramework=".NETCoreApp5.0"> |
There was a problem hiding this comment.
Wouldn't it be better to target :
netstandard2.0over.NETCoreApp3.1net5.0over.NETCoreApp5.0
There was a problem hiding this comment.
I could not compile netstandard with any of dependencies - anyway if you have some idea please share i will modify pr
There was a problem hiding this comment.
Looking at nuget.org I think we could change .NETCoreApp5.0 to net5.0 as Microsoft.PowerShell.SDK v7.1.2 has net5.0 dependencies but your right I don't think there's anything we can do with .NETCoreApp3.1 as Microsoft.PowerShell.SDK v7.0.5 only has .NETCoreApp3.1 dependencies and the latest preview package jumps straight to net6.0.
The test project would probably still need to be .NETCoreApp5.0 but in theory, the addin could target net5.0. I haven't checked if this would compile though, so I happy to be proven wrong.
There was a problem hiding this comment.
Hmm I used nuget package explorer - and for example net5.0 is saved as .NETCoreApp5.0. Could you please advise what could I change? test project is also targeting 3 frameworks
AdaskoTheBeAsT
force-pushed
the
feature/cross-platform
branch
from
13b1fdd to
0daaab2
Compare
|
Awesome work @AdaskoTheBeAsT! 🍻 |
|
@augustoproiete thank you :) happy to help community. |
Initial implementation cross platform powershell