Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed alignments should be handled #91

Open
ressy opened this issue Aug 20, 2020 · 2 comments
Open

Failed alignments should be handled #91

ressy opened this issue Aug 20, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@ressy
Copy link
Member

ressy commented Aug 20, 2020

Currently an alignment directory with incomplete output from a processing failure on the sequencer triggers a repeating "Alignment not recognized" error for the run, but that's only because the wrong ValueError is inadvertently caught. The Checkpoint.txt file for these cases is both an integer and a keyword (and the keyword gets included when trying to cast as int in umbra.illumna.util.load_checkpoint).

In these cases Checkpoint.txt looks like:

0
Demultiplexing

instead of:

3

(So there's an empty string in the usual case, and presumably other integers and keywords for the intermediates but I haven't seen them.)

Instead, load_checkpoint should be updated to get both the integer and the keyword, and any error entries in CompletedJobInfo.xml should be noted.

@ressy ressy added the bug Something isn't working label Aug 20, 2020
@ressy ressy added this to the Version 0.0.4 milestone Aug 20, 2020
@ressy
Copy link
Member Author

ressy commented Aug 20, 2020

The examples I can find are:

0
Demultiplexing
1
Generating FASTQ Files
3

Whatever step 2 is it must happen very reliably.

@ressy ressy modified the milestones: Version 0.0.4, Version 0.1.0 Aug 31, 2020
@ressy ressy added enhancement New feature or request and removed bug Something isn't working labels Sep 17, 2020
@ressy
Copy link
Member Author

ressy commented Sep 17, 2020

The bug aspect of this was fixed in #97 and the error parsing implemented in #104. The last step is to add a property summarizing current state (e.g. incomplete, errored, complete) and add it to the processor reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant