New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is project being maintained? #20

Open
stonedauwg opened this Issue Sep 26, 2018 · 16 comments

Comments

Projects
None yet
5 participants
@stonedauwg
Copy link

stonedauwg commented Sep 26, 2018

There are pull requests and almost no follow-ups to Issues. This is a great project @ShawnMoore , would be a shame to let it die :)

@dingwilson

This comment has been minimized.

Copy link
Contributor

dingwilson commented Sep 28, 2018

Please see #14 . I'm currently maintaining a fork of the library. @ShawnMoore merged my PR to framework-ify this repo, but then did not tag the repo so that we could actually consume it as a framework. :/ I've gone ahead and tagged my fork, and published for all to use.

@stonedauwg

This comment has been minimized.

Copy link
Author

stonedauwg commented Sep 28, 2018

Perfect. Thanks @dingwilson. Glad to see it live on

@regexident

This comment has been minimized.

Copy link

regexident commented Oct 1, 2018

For what it's worth I just submitted four fixes …

… and would be happy to help out maintaining the project, if you'd add me as a contributor, @ShawnMoore (and maybe even create an org for it?).

@dingwilson

This comment has been minimized.

Copy link
Contributor

dingwilson commented Oct 1, 2018

@ShawnMoore I saw that you made a few commits to the repo. Will you continue maintaining this project? If so, would you like me to transfer the ownership of the CocoaPod to you?

@regexident

This comment has been minimized.

Copy link

regexident commented Oct 5, 2018

Make that five 🤓:

Next-up: adding fixed-order encoding and I'll finally be able to write GPX. 😑

@stonedauwg

This comment has been minimized.

Copy link
Author

stonedauwg commented Oct 5, 2018

Just curious, is there a way to grant someone else privileges to accept PQ's?

@dingwilson

This comment has been minimized.

Copy link
Contributor

dingwilson commented Oct 5, 2018

@stonedauwg yes there is. @ShawnMoore would have to add the person as a collaborator, but then that person would have write access to the repo, and would be able to merge PRs.

@regexident

This comment has been minimized.

Copy link

regexident commented Oct 5, 2018

Yes, “collaborator” is what I meant, not “contributor”. Thanks @dingwilson !

Collaborator does not necessarily mean “sudo” though. GitHub allows for protecting a branch, so that e.g. at least one collaborator needs to accept via code review, etc. But given @ShawnMoore ‘s apparent rare activity here that’d probably defeat the purpose to a certain degree.

If it was my project I’d move it into an org to reduce the burden and select 2 collaborators to help out with the maintainance/development. Then I’d add mandatory code review to ensure quality control etc (2 collaborators so that there’s enough movement in merging/responding to PRs).

And last but not least once the project has reached a reasonable level of maturity I'd go for a proposal to add the implementation to Swift's stdlib (either verbatim/modified or have it at least act as a proof of concept accompanying an evolution proposal). 🙃

@regexident

This comment has been minimized.

Copy link

regexident commented Oct 23, 2018

@ShawnMoore could you chime in on this topic?

ShawnMoore/XMLParsing has the potential of filling a major gap in the Swift stdlib.
Yet there is lots of stuff piling up here with no apparent future for the project in sight.

@MaxDesiatov

This comment has been minimized.

Copy link

MaxDesiatov commented Oct 27, 2018

Hey all, many thanks for you contributions, I think I've cherry-picked most if not all mergeable PRs, you folks created recently, within my fork and added a new key decoding strategy on top of that and a first unit-test.

@ShawnMoore I'm happy to create to a new PR within this project if there's any chance this project is not abandoned after all.

Otherwise, please feel free to use my fork: https://github.com/maxdesiatov/XMLParsing/

@MaxDesiatov

This comment has been minimized.

Copy link

MaxDesiatov commented Nov 8, 2018

Turns out, you can't have a podspec dependency that's a fork with the same name. Unfortunately, because I have a new library with a podspec that depended on my XMLParsing fork, I had to pick a different name like XMLCoder. I hope you might be interested in using the new renamed fork while the original XMLParsing looks as not being maintained.

XMLCoder includes contributions from unmerged PRs to XMLParsing from @regexident, @edc1591, @salavert and @Lutzifer. It also adds unit-tests and Travis CI builds on top of that and I'm very happy to merge more contributions if anyone's interested.

Thanks.

@Lutzifer

This comment has been minimized.

Copy link

Lutzifer commented Nov 8, 2018

good job @MaxDesiatov

@regexident

This comment has been minimized.

Copy link

regexident commented Nov 8, 2018

Thanks, @MaxDesiatov!

Looks like I'll be doing any future work by contributing to XMLCoder then. 💪
Shame to see a hard fork end up being the only viable option, though. 😕

@MaxDesiatov

This comment has been minimized.

Copy link

MaxDesiatov commented Nov 8, 2018

Thank you for the feedback, I have same concerns, happy to hear any suggestions with workarounds if possible.

@ShawnMoore I'm happy to submit PRs with my changes and merge the fork back, please let me know if there's any chance those could be reviewed. Thank you for creating the original library!

@regexident

This comment has been minimized.

Copy link

regexident commented Nov 8, 2018

Agreed.

Btw, what’s your stance on creating an organization (with say the most active current contributors as collaborators to get things started) to encourage more contributions from others and ensure it stays alive for good?

@MaxDesiatov

This comment has been minimized.

Copy link

MaxDesiatov commented Nov 8, 2018

As far as I know, collaborators can be added to public repositories that even aren't attached to an organisation. I'd like to wait a bit and see if XMLCoder gets any traction, PRs, issues and active contributors in general, happy to add maintainers based on the amount of contributions.

I do plan to set up an organisation for maintaining a few more Swift libraries under the same umbrella. But again that's a future plan that totally depends on the amount of external interest there libraries would get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment