Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed use of precondition(…) testing for container emptyness #24

Closed
wants to merge 1 commit into from
Closed

Fixed use of precondition(…) testing for container emptyness #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/XMLParsing/Decoder/XMLDecodingStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ internal struct _XMLDecodingStorage {
}

internal var topContainer: Any {
precondition(self.containers.isEmpty, "Empty container stack.")
precondition(!self.containers.isEmpty, "Empty container stack.")
return self.containers.last!
}

Expand All @@ -38,7 +38,7 @@ internal struct _XMLDecodingStorage {
}

internal mutating func popContainer() {
precondition(self.containers.isEmpty, "Empty container stack.")
precondition(!self.containers.isEmpty, "Empty container stack.")
self.containers.removeLast()
}
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/XMLParsing/Encoder/XMLEncodingStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ internal struct _XMLEncodingStorage {
}

internal mutating func popContainer() -> NSObject {
precondition(self.containers.isEmpty, "Empty container stack.")
precondition(!self.containers.isEmpty, "Empty container stack.")
return self.containers.popLast()!
}
}