rabbitmq tested and working

ShawnSpooner · Nov 7, 2008 · 9bce1e3 · 9bce1e3
1 parent c3a5db9
commit 9bce1e3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/lib/workling/clients/amqp_client.rb b/lib/workling/clients/amqp_client.rb
@@ -11,8 +11,9 @@ class AmqpClient < Workling::Clients::Base
       # starts the client. 
       def connect; @amq = MQ.new; end
 
-      # disconnect from the queue server
-      def close; @amq.close; end
+      # no need for explicit closing. when the event loop
+      # terminates, the connection is closed anyway. 
+      def close; true; end
 
       # subscribe to a queue
       def subscribe(key)

diff --git a/lib/workling/remote/runners/ampq_runner.rb b/lib/workling/remote/runners/ampq_runner.rb
@@ -20,6 +20,7 @@ def run(clazz, method, options = {})
           # neet to connect in here as opposed to the constructor, since the EM loop is
           # not available there. 
           @connected ||= AmpqRunner.client.connect
+
           AmpqRunner.client.request(@@routing.queue_for(clazz, method), options)    
 
           return nil

diff --git a/lib/workling/remote/runners/starling_runner.rb b/lib/workling/remote/runners/starling_runner.rb
@@ -20,12 +20,15 @@ class StarlingRunner < Workling::Remote::Runners::Base
 
         def initialize
           StarlingRunner.client = Workling::Clients::MemcacheQueueClient.new
-          StarlingRunner.client.connect
           StarlingRunner.routing = Workling::Routing::ClassAndMethodRouting.new
         end
 
         # enqueues the job onto Starling. 
         def run(clazz, method, options = {})
+
+          # connecting in here avoids exceptions when running rake tasks etc
+          @connected ||= StarlingRunner.client.connect
+
           StarlingRunner.client.request(@@routing.queue_for(clazz, method), options)
 
           return nil # empty.