fix parse_si for Japanese excel files #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. using #parse_si 'Phonetic Properties' items for Japanese excel files, the Phonetic items(KATAKANA) represents pronunciation hints of String(KANJI). ``` <si> <t>漢字(japanese KANJI)</t> <rPh> <t>フリガナ(this is KATAKANA for pronounciation:漢字)</t> </rPh> </si> ``` It expected get '漢字' . but got '漢字フリガナ'. so replace these string, because this can be caused by only `<rPh>`.
|
@tgfjt do you have a sample file that shows this? I'd like to set up some tests as well |
|
@SheetJSDev It seems to be caused by colored KANJI:sweat: |
|
@SheetJSDev |
|
ping:sob: @SheetJSDev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
using #parse_si 'Phonetic Properties' items for Japanese excel files,
the Phonetic items(KATAKANA) represents pronunciation hints of String(KANJI).
It expected get '漢字' . but got '漢字フリガナ'.
so replace these string, because this can be caused by only
<rPh>.