Fixing error with missing .Props file #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zip.file` uses `wb.Props` but if `.Props` is undefined it will throw an error. Seems like the safeguard from a few lines below should be before `zip.file`
|
Thanks @martinheidegger a bunch of related potentially-undefined tests were added |
saarCiklum
pushed a commit
to Folcon/js-xlsx
that referenced
this pull request
Aug 17, 2020
- basic support for parsing BIFF2-4 - basic support for writing BIFF2 - cleaned up some bad substr uses for IE6 compatibility - added flow type annotations for xlsx.flow.js - added numerous null guards (fixes SheetJS#255 h/t @martinheidegger) - README cleanup (fixes SheetJS#539 h/t @oliversalzburg) - pin jszip to local version (closes SheetJS#408 h/t @limouri) bower issues: | id | author | comment | |-----:|:------------------|:------------------------------------------| | SheetJS#254 | @kkirsche | fixes SheetJS#254 by removing version from json | | protobi#165 | @vincentcialdella | fixes protobi#165 by changing default script | | protobi#180 | @owencraig | fixes protobi#180 by using xlsx.core.min.js | format issues: | id | author | comment | |-----:|:------------------|:------------------------------------------| | SheetJS#271 | @morstaine | fixes SheetJS#271 by reworking related parse fns | | SheetJS#504 | @JanSchuermannPH | fixes SheetJS#504 detect FullPaths h/t @Mithgol | | SheetJS#508 | @basma-emad | fixes SheetJS#508 offending file used `x:` NS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zip.fileuseswb.Propsbut if.Propsis undefined it will throw an error. Seems like the safeguard from a few lines below should be beforezip.file