Modularity fix & sheet_to_csv option #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove broken link
Add notes for bordering merged cells
Add additional font style options
Add syntax highlighting to readme examples
…sing StyleBuilder
Breaks references in style objects
|
We've improved the bundler usage. There are other pull requests covering the blank rows, and I think a better approach is to just keep track of whether the row is blank rather than regexing at the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue in xlsx.js which was causing bundlers to be unable to use and added an "ignoreBlankRows" option that sheet_to_csv() can take so that it skips rows which are entirely blank.