New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load large set of data #20

Merged
merged 12 commits into from Jul 22, 2018

Conversation

Projects
None yet
2 participants
@Prakriti-nith
Contributor

Prakriti-nith commented Jul 5, 2018

This PR runs in parallel with daru-view#104.

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Jul 6, 2018

Now, DataTables can work with a large dataset too (~5000000, above it may cause problems). This much of data can not loaded using client-side processing as browser hangs. Here are the screenshots for the implemented code:

Including this in controller:
datatable_ajax_controller

We can see that it is generating the datatable for 2000000 rows.
datatable_ajax

@Prakriti-nith Prakriti-nith changed the title from Added attr_accessor data and fix rubocop offences to [WIP] Load large set of data Jul 6, 2018

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Jul 12, 2018

I have kept client-side processing (using data option and providing js array) for below 50000 rows and server-side above that. It is because, in server-side processing, the searching option is not working properly.

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Jul 14, 2018

I have updated the API, done some refactoring, added docs and tests along with the feature to load large set of data(above 50000 rows). For small dataset, client-side processing is used with data being provided as js array rather than HTML table (HTML table supports only 5000 rows).

@Prakriti-nith Prakriti-nith changed the title from [WIP] Load large set of data to Load large set of data Jul 14, 2018

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Jul 22, 2018

Rails examples added in this PR screenshots:
rails1
rails2
rails3
rails4

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Jul 22, 2018

@Shekharrajak can you please review this PR?

@Shekharrajak

Some methods are not documented. We should do it in other PRs.

@@ -50,6 +52,8 @@ def typecast(value, type=nil)
value
end
end
end # module ParamHelpers end
# rubocop:enable Metrics/PerceivedComplexity, Metrics/MethodLength

This comment has been minimized.

@Shekharrajak

Shekharrajak Jul 22, 2018

Owner

Will try to fix these in other PRs

@Shekharrajak Shekharrajak merged commit e47615f into Shekharrajak:master Jul 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Shekharrajak

This comment has been minimized.

Owner

Shekharrajak commented Jul 22, 2018

Thanks!

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Jul 22, 2018

closes #19

@Shekharrajak Shekharrajak referenced this pull request Aug 23, 2018

Open

Add specs #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment