New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bunch of js lines in rails #23

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@Prakriti-nith
Contributor

Prakriti-nith commented Aug 3, 2018

This PR aims to remove a bunch of lines that occur in the head tag in rails. Dependent JS and CSS files are shifted to vendor/assets/javascripts and vendor/assets/stylesheets respectively. JS can be included in the app/assets/javascripts/application.js file as:

//= require jquery-latest.min
//= require jquery.dataTables

CSS files can be included as:

 *= require jquery.dataTables

and include the below lines in the head of the layout file:

<%= javascript_include_tag "application" %>
<%= stylesheet_link_tag "application" %>

Note: The previous method to use <%=raw Daru::DataTables.init_script %> will also work.

@coveralls

This comment has been minimized.

coveralls commented Aug 3, 2018

Pull Request Test Coverage Report for Build 21

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 233
Relevant Lines: 233

💛 - Coveralls

@Shekharrajak Shekharrajak merged commit 660c309 into Shekharrajak:master Aug 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@Shekharrajak

This comment has been minimized.

Owner

Shekharrajak commented Aug 4, 2018

Examples for these changes has to be done.

@Prakriti-nith

This comment has been minimized.

Contributor

Prakriti-nith commented Aug 5, 2018

Refer commit for examples in dummy_rails.

dtbol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment