Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Update Functions.lua
- Loading branch information
Showing
1 changed file
with
8 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this function do ?
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using it in the PTR version, as part of skinning in Naval skin. Changed in wrong version here. Will be in use from 6.2
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it T:HandleIcon? or T.HandleIcon?
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be T.HandleIcon, didn't see it when posting. Since i made edit in wrong version, and the edit didn't cause anything im just waiting to merge in rest of 6.2 changes. Using it to skin icons, like in questchoice.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can i read 6.2 PTR code?
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, just make pull request in it.
https://github.com/Shestak/ShestakUI/tree/PTR-6.2
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on fixing the skinning for scrollbars.
Maybe just ask you. Can you see any reason why the top arrow for scrollbar points down?
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use skin in blizzard frame, What's wrong with scrollbars?
Maybe you can reference AddOnSkins function.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will test this function, afternoon,
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there isn't any skinning of scrollbars and from what i see, not for a long time. The code skins correctly everything, it's only that the top arrow points down. Not sure if it's T.SkinNextPrevButton that messes it up.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In function T.SkinNextPrevButton(btn, horizontal, left)
Three icons are all arrow points down.I don't think that the function(T.SkinNextPrevButton) apply to the ScrollBar.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bahh, can't belive i didn't see that. I even checked it.. Eyes stopped at "up" and "down", and brain never kicked in saying it was buttonpressed down/up and not icon. Will start looking into it.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it could be:
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess that could work. I have a working version on PTR. I'll look into it later to see if it's better solution.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have e-mail? I'll send buff/debuff list of HFC RAID to you.
1b75fce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sendt you a PM on forum with email.