Add VSYASM download link in FFmpeg/SMP/readme.txt #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YASM is required by project under Visual Studio Solution ffmpeg_deps.sln including libass.vcxproj, libgmp.vcxproj, libgnutls.vcxproj, libhogweed.vcxproj, libnettle.vcxproj, libvpx.vcxproj and libxvidcore.vcxproj.
|
To build ffmpeg only NASM can be used so i wanted to be clear on that. As for YASM dependency that can change based on what the dependencies require. So i dont explicitly state it in ffmpeg as whenever a dependency changes then ffmpeg has to be changed as well. Which is why in the readme i refer users to the readme of the dependencies to see what they need with:
Although i did fix a typo in the readme that you spotted. |
|
Ok, thanks for explanation |
|
Just, as a beginner, I was so confused when those dependencies requiring YASM failed to be loaded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
YASM is required by projects under Visual Studio Solution ffmpeg_deps.sln including libass.vcxproj, libgmp.vcxproj, libgnutls.vcxproj, libhogweed.vcxproj, libnettle.vcxproj, libvpx.vcxproj and libxvidcore.vcxproj.
It would be better to add download link of VSYASM