Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #8

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mtstickney
Copy link

mtstickney commented Mar 7, 2019

Some relatively minor adjustments to load on SBCL without warnings. Consists of avoiding some function redefinitions, and reordering to put inline declarations before call sites..

mtstickney added some commits Mar 7, 2019

Avoid defining functions twice.
STACK and RESTARTS are defined by individual backends, so defining them
in the interface leads to a redefinition warning when the backend is
loaded. The others have specialized implementations for the SBCL
backend, so make sure the default implementation isn't loaded on SBCL to
avoid redefinition warnings.
Define inlined function before use.
Since the function is declared inline, we want the inline declaration
and the definition to precede any call sites, to avoid a warning about
retroactive inlining.
@Shinmera
Copy link
Owner

Shinmera left a comment

These changes break other implementations and leak implementation details into the general interface

@@ -8,18 +8,18 @@

(declaim (ftype (function () list) stack restarts)
(notinline stack restarts))
(defun stack ())

(defun restarts ())

This comment has been minimized.

@Shinmera

Shinmera Mar 7, 2019

Owner

This breaks the API on unsupported implementations.


(declaim (notinline stack-truncator))
#-sbcl

This comment has been minimized.

@Shinmera

Shinmera Mar 7, 2019

Owner

I don't want implementation-specific code in the general interface.

@Shinmera

This comment has been minimized.

Copy link
Owner

Shinmera commented Mar 7, 2019

This "problem" is known and I don't consider it to be one.

@Shinmera Shinmera closed this Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.