Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wind #56

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Wind #56

merged 2 commits into from
Jul 17, 2023

Conversation

hinata235
Copy link
Contributor

Modified problem with tests not running.
I have confirmed that the test code runs.

data.jl

  • Delete Tu_wind and Tψ_wind from ShipData.

test_mmg.jl

  • Adding variables related to wind(μ_u_wind,μ_ψ_wind,σ_u_wind,σ_ψ_wind,u_wind_list, ψ_wind_list).

@hinata235
Add files via upload
c34247f 
Delete Tu_wind,Tψ_wind from ShipData.
@hinata235
Add files via upload
cb60a61 
Add wind variables and structure_params.
@taiga4112 taiga4112 self-requested a review July 17, 2023 03:34
@taiga4112 taiga4112 changed the base branch from dev to feature/wind_force July 17, 2023 03:50
taiga4112
taiga4112 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@taiga4112 taiga4112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will consider an adequate code structure from this PR.

@taiga4112 taiga4112 merged commit 203ad5b into ShipMMG:feature/wind_force Jul 17, 2023
1 check passed
@taiga4112 taiga4112 mentioned this pull request Jul 17, 2023
Open
@hinata235 hinata235 deleted the wind branch June 12, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiga4112 taiga4112 taiga4112 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hinata235 @taiga4112