New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for display issues star rating #68

Merged
merged 4 commits into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@bertrey

bertrey commented Mar 25, 2018

This should resolve #67

@ElementalCrisis ElementalCrisis requested review from maxpiva and RickDB Mar 25, 2018

@RickDB

This comment has been minimized.

Contributor

RickDB commented Apr 6, 2018

Looks good and gonna merge 👍

Btw for combining strings like in the 2nd commit I usually use string interpolation as it's cleaner and less error prone but takes some getting used to :)

@RickDB RickDB merged commit b8d2593 into ShokoAnime:master Apr 6, 2018

@RickDB

Fixes the rating with some added validations, see no issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment