Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing A Group AND Not Saving Blanks Group #576

Closed
ElementalCrisis opened this issue Jan 10, 2018 · 3 comments · Fixed by #602
Labels
Milestone

Comments

@ElementalCrisis
Copy link
Member

@ElementalCrisis ElementalCrisis commented Jan 10, 2018

VERSION INFORMATION

Server Version: 3.8.2.35
Desktop Version: 3.8.2

If you've compiled your own version, please use the last commit you compiled.

DESCRIPTION

Editing a group but making no changes blanks the group and sort name.

STEPS TO REPRODUCE

  1. Select group to edit.
  2. Cancel edit.

2018-01-09_17-19-16

@da3dsoul

This comment has been minimized.

Copy link
Member

@da3dsoul da3dsoul commented Jan 10, 2018

Does restarting bring it back, or does it actually wipe the titles?

@ElementalCrisis

This comment has been minimized.

Copy link
Member Author

@ElementalCrisis ElementalCrisis commented Jan 10, 2018

Restarting brings it back, however running Recreate All Groups while its gone freezes the Collection tab and the series panel appears on filter listing.

@da3dsoul da3dsoul added this to the Release 3.9 milestone Jun 13, 2018
@da3dsoul da3dsoul removed their assignment Jun 14, 2018
@da3dsoul

This comment has been minimized.

Copy link
Member

@da3dsoul da3dsoul commented Jun 14, 2018

Unassigning myself, because I don't wanna.

Mik1ll added a commit to Mik1ll/ShokoDesktop that referenced this issue Aug 23, 2019
Use a shallow copy to cancel changes instead of extension method.
Mik1ll added a commit to Mik1ll/ShokoDesktop that referenced this issue Aug 24, 2019
Old field values should be saved in case of cancelling edit of group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.