Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add 'Company' field to shipwire request #11

merged 1 commit into from Jul 6, 2012


None yet
3 participants

boourns commented Jul 5, 2012

Add 'Company' field to shipwire request instead of injecting it into Address fields

Please review @jduff and @Soleone


Soleone commented Jul 5, 2012

Looks good to me 👍

Just double checking with Shipwire support that it's okay to send an empty Company XML element in case it hasn't been provided to us.


jduff commented Jul 5, 2012

As long as company can be blank, :shipit:


Soleone commented Jul 5, 2012

Shipwire responded and said:

We'll ignore if it's empty, so it's fine always to provide it, for rating and fulfillment requests.


boourns pushed a commit that referenced this pull request Jul 6, 2012

Merge pull request #11 from Shopify/add_company_tag_to_shipwire_fulfi…

Add 'Company' field to shipwire request

@boourns boourns merged commit 9c09d49 into master Jul 6, 2012

@kevinhughes27 kevinhughes27 deleted the add_company_tag_to_shipwire_fulfillment branch Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment