Bugfix/extract all tracking numbers from amazon mws #18

Merged
merged 2 commits into from Jan 3, 2013

Projects

None yet

3 participants

@csaunders
Contributor

Major change to the API so bump version to 2.0.0

All calls to tracking_numbers returns arrays. This also fixes up an issue where the MWS integration was only returning a single tracking number even tough, multiple tracking numbers could be returned from Amazons fulfillment API.

please review @jduff @odorcicd

Chris Saunders added some commits Oct 4, 2012
Chris Saunders Ensure that all tracking numbers for a fulfillment are retrieved
In order to not fully hose the API, we return all tracking numbers
as a comma separated string.  This should fix any issues related with
having an order be fulfilled via multiple fulfillment centers (hence
the requirement for different tracking numbers)
4383e43
Chris Saunders Extract tracking number information into arrays
Instead of giving back a string for tracking numbers we
return arrays instead.  This is a backwards-incompatible change,
and as such requires a major version update.  All current fulfillment
providers, and future providers will need to providing tracking
numbers as arrays, even if it is guaranteed that they only provide
a single tracking number.
096eb12
@csaunders
Contributor

last commit was a force push, hence the same commit message. apologies.

@jduff
Member
jduff commented Jan 3, 2013

Nothing jumps out to me.

@odorcicd
odorcicd commented Jan 3, 2013

me neither

@csaunders csaunders merged commit 3eb12cc into Shopify:master Jan 3, 2013
@csaunders csaunders deleted the unknown repository branch Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment