Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Order Comments are not required for fulfillments #5

Merged
merged 1 commit into from

1 participant

@csaunders
Collaborator

So it shouldn't matter if they are there or not.

@csaunders csaunders merged commit 84fa373 into Shopify:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 28, 2012
  1. @csaunders

    Fulfillment comments aren't required by the amazon API, so it shouldn't

    csaunders authored
    matter if they are there or not.
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 5 deletions.
  1. +0 −5 test/unit/services/amazon_mws_test.rb
View
5 test/unit/services/amazon_mws_test.rb
@@ -159,11 +159,6 @@ def test_invalid_arguments
assert_equal "MalformedInput: timestamp must follow ISO8601", response.params['response_comment']
end
- def test_missing_order_comment
- @options.delete(:comment)
- assert_raise(ArgumentError) { @service.fulfill('12345678', @address, @line_items, @options) }
- end
-
def test_missing_order_date
@options.delete(:order_date)
assert_raise(ArgumentError) { @service.fulfill('12345678', @address, @line_items, @options) }
Something went wrong with that request. Please try again.