Fix Package#cents_from incorrectly converting from an inprecise Float…

… to Integer
Shopify · Sep 12, 2011 · d017ff6 · d017ff6
1 parent c4d6a41
commit d017ff6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/active_shipping/shipping/package.rb b/lib/active_shipping/shipping/package.rb
@@ -98,9 +98,9 @@ def self.cents_from(money)
         else
           case money
           when Float
-            (money * 100).to_i
+            (money * 100).round
           when String
-            money =~ /\./ ? (money.to_f * 100).to_i : money.to_i
+            money =~ /\./ ? (money.to_f * 100).round : money.to_i
           else
             money.to_i
           end
@@ -144,4 +144,4 @@ def process_dimensions
 
     end
   end
-end
+end
diff --git a/test/unit/carriers/kunaki_test.rb b/test/unit/carriers/kunaki_test.rb
@@ -48,6 +48,6 @@ def test_successfully_get_rates
     assert_equal "USPS", rate.carrier
     assert_equal 800, rate.total_price
     assert_equal ["UPS 2nd Day Air", "UPS Ground", "UPS Next Day Air Saver", "USPS Priority Mail"], response.rates.collect(&:service_name).sort
-    assert_equal [800, 1234, 2186, 3604], response.rates.collect(&:total_price).sort
+    assert_equal [800, 1234, 2186, 3605], response.rates.collect(&:total_price).sort
   end
-end
+end