Better ShipWire validation #132

Open
christianblais opened this Issue Jan 7, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@christianblais
Member

christianblais commented Jan 7, 2014

Rel.: #130

There is currently no validation on Shipwire XML responses. We simply transform all NoMethodError into ResponseContentError.

As suggested by @costford, a better implementation would be to do an initial full response validation with something like an .xsd, or individually ensuring the presence of each node you want to work with.

@csaunders

This comment has been minimized.

Show comment Hide comment
@csaunders

csaunders Jan 7, 2014

Contributor

🏩

Contributor

csaunders commented Jan 7, 2014

🏩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment