USPS: Return false for canned_address_verification_works? if login is nil #149

Merged
merged 1 commit into from Feb 20, 2014

Projects

None yet

3 participants

Member

Was getting NoMethodError: undefined methodgsub' for nil:NilClass` if USPS carrier was created without any LoginID specified.

Added a return false if the login is nil to prevent the exception.

Review: @maartenvg @dylanahsmith

Member

LGTM

@nsimmons nsimmons merged commit ce97bff into master Feb 20, 2014

1 check passed

default The Travis CI build passed
Details
@nsimmons nsimmons deleted the fix_nomethoderror_empty_usps_login branch Feb 20, 2014
Member

Cool, :shipit:

Member

A bit too late i see. Oops

@kknd113 kknd113 pushed a commit to dotandbo/active_shipping that referenced this pull request May 12, 2015
@dpritchett @radar dpritchett + radar Updated routes.rb to use :add_routes for 2.1
Fixes #149
2148d88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment