Add Company tag to shipwire rates request #53

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

boourns commented Jul 5, 2012

Add explicit tag to Shipwire API rates request if company is provided in destination shipping address.

If input company is blank no tag is sent so it avoids questions re: blank company tags.

Please review @Soleone & @jduff

Member

Soleone commented Jul 5, 2012

We can probably just add the company to an existing location instead of creating a new one, but apart from that 👍

Contributor

jduff commented Jul 5, 2012

nothing more to add, :shipit:

boourns commented Jul 5, 2012

added commit to remove new fixture

@Soleone Soleone commented on an outdated diff Jul 5, 2012

test/test_helper.rb
@@ -195,7 +196,7 @@ module TestFixtures
:country => 'NZ',
:city => 'Auckland',
:address1 => '192 Victoria St West',
- :postal_code => '1010')
+ :postal_code => '1010'),
}
@Soleone

Soleone Jul 5, 2012

Member

Accidental trailing comma slipt in here. Won't cause an issue but I would just amend the commit and remove this chunk from it.

Member

Soleone commented Jul 5, 2012

Tiny comment inline, but otherwise :shipit:

Contributor

jduff commented Jul 5, 2012

:shipit:

Contributor

jduff commented Aug 4, 2012

closed by 3e5b411

jduff closed this Aug 4, 2012

garethson deleted the shipwire_add_company_tag_to_address branch Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment