Fix CI #8
Merged
Fix CI #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look like SQLite 3 kinda changed it's format. I'm on it. |
byroot
force-pushed
the
mysql2-version
branch
from
e97ee7c
to
84f4006
Compare
Closed
byroot
force-pushed
the
mysql2-version
branch
2 times, most recently
from
9c49283
to
5b81af0
Compare
|
FFS there is just so many different issues with the test suite -_-. I'm getting close though. |
byroot
force-pushed
the
mysql2-version
branch
3 times, most recently
from
6fadfa6
to
0d3acd5
Compare
byroot
force-pushed
the
mysql2-version
branch
from
0d3acd5
to
4d9b9bf
Compare
|
All green! I'll add a few comments about what changed and why. |
| - gemfiles/Gemfile.ar-4.0 | ||
| - gemfiles/Gemfile.ar-4.1 | ||
| - gemfiles/Gemfile.ar-4.2 | ||
| - gemfiles/Gemfile.ar-edge |
There was a problem hiding this comment.
I moved the Gemfile outside of spec because otherwise gems were installed in spec/gemfiles/bundler and rspec was trying to runt he dependencies specs.
| end | ||
|
|
||
| def extract_columns(columns_string) | ||
| return unless columns_string | ||
| columns_string.split(",").map(&:strip) | ||
| columns_string.split(",").map { |column| column.split('.').last.strip } |
There was a problem hiding this comment.
Right. This is because in that new format, columns are in their "fully qualified names", e.g. table_name.column_name, not just column_name
|
👍 |
byroot
added a commit
that referenced
this pull request
Sep 30, 2015
arthurnn
pushed a commit
to arthurnn/activerecord-rescue_from_duplicate
that referenced
this pull request
Sep 30, 2015
gmalette
added a commit
that referenced
this pull request
Sep 30, 2015
You forgot to change the readme in #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the mysql2 version should fix CI.
cc @arthurnn @gmalette