Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepend and append to ChangeObserver #361

Merged
merged 1 commit into from May 5, 2021
Merged

Conversation

@psparrow
Copy link
Contributor

@psparrow psparrow commented May 5, 2021

This PR adds prepend and append to ChangeObserver to make bootsnap compatible with code that uses those methods to modify the $LOAD_PATH.

@psparrow psparrow marked this pull request as draft May 5, 2021
@psparrow psparrow marked this pull request as ready for review May 5, 2021
@casperisfine
Copy link
Contributor

@casperisfine casperisfine commented May 5, 2021

LGTM. Please squash your commits into a single one, and I'll merge.

@casperisfine
Copy link
Contributor

@casperisfine casperisfine commented May 5, 2021

Looks like the test failure is legit.

@psparrow
Copy link
Contributor Author

@psparrow psparrow commented May 5, 2021

Looks like the test failure is legit.

Fixed. I moved the reinitialization test to a separate example for readability.

@casperisfine casperisfine merged commit ba68d31 into Shopify:master May 5, 2021
12 checks passed
@casperisfine
Copy link
Contributor

@casperisfine casperisfine commented May 5, 2021

Thanks.

@shopify-shipit shopify-shipit bot deployed to rubygems May 5, 2021 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants