Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer checkout creation to when variants are added to cart #657

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@spencercanner
Copy link
Contributor

spencercanner commented Nov 14, 2019

  • Reconfigure cart component to only create a checkout when an item is added to cart
  • Add additional checks when accessing data from the cart model, since it won't always be defined
@spencercanner spencercanner force-pushed the prevent-empty-cart-creation branch from b45df8d to d8f6607 Nov 14, 2019
@spencercanner spencercanner force-pushed the prevent-empty-cart-creation branch from 6a86d96 to a3904af Nov 18, 2019
@spencercanner spencercanner changed the title [WIP] Defer checkout creation to when variants are added to cart Defer checkout creation to when variants are added to cart Nov 18, 2019
Copy link
Contributor

melissaluu left a comment

👍 Looks good

@spencercanner spencercanner merged commit 2a7950e into master Nov 19, 2019
3 checks passed
3 checks passed
CLA Contributor License Agreement (CLA) status
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@spencercanner spencercanner deployed to production Nov 19, 2019 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.