Add quicktype package dependency to dev.yml#24
Merged
Merged
Conversation
markmur
force-pushed
the
package-deps
branch
3 times, most recently
from
1e6f4d5 to
e66536a
Compare
Base automatically changed from
05-05-add_ecp_support_to_android_checkout_kit
to
main
May 6, 2026 20:28
markmur
force-pushed
the
package-deps
branch
5 times, most recently
from
4b9b2ae to
70a617d
Compare
markmur
commented
May 8, 2026
|
|
||
| excluded: | ||
| - swift/Samples | ||
| - swift/Sources/ShopifyCheckoutKit/Models.swift |
Contributor
Author
There was a problem hiding this comment.
I'm not adding the generated file in this PR because CI is having issues with license, linting, compilation etc. Will add it in a follow up
kiftio
approved these changes
May 8, 2026
|
|
||
| up: | ||
| - packages: | ||
| - quicktype |
Contributor
There was a problem hiding this comment.
Wondering if pnpx would be a better approach - dev up wont work in CI, and I think we want to automate the releases?
Approving anyway as we probably wont set that up in this week
Contributor
Author
There was a problem hiding this comment.
Yeah happy to revisit this next week
kieran-osgood-shopify
approved these changes
May 8, 2026
kieran-osgood-shopify
pushed a commit
that referenced
this pull request
May 8, 2026
kieran-osgood-shopify
pushed a commit
that referenced
this pull request
May 8, 2026
kieran-osgood-shopify
pushed a commit
that referenced
this pull request
May 8, 2026
kieran-osgood-shopify
pushed a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds quicktype as a package dependency to the dev.yml. The Model.swift file will be added in a follow up.
Before you merge
Important
swift/README.mdand/orandroid/README.md)Releasing a new Swift version?
swift/ShopifyCheckoutKit.podspecswift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftswift/CHANGELOG.mdswift/README.md(major version only)Releasing a new Android version?
versionNameinandroid/lib/build.gradleandroid/CHANGELOG.mdandroid/README.mdTip
See the Contributing documentation for the full release process per platform.