Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix max duration setter #103

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
2 participants
@doodzik
Copy link
Member

commented Jul 11, 2019

We aren't using the the max_duration flag setter in the configuration initializer. This prevents it to be added to the circuit breakers.

ref #102

@doodzik doodzik requested review from casperisfine and Shopify/pipeline Jul 11, 2019

@DazWorrall
Copy link
Member

left a comment

Would be good to see a regression test for this.

@doodzik

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Would be good to see a regression test for this.

I think in this case it isn't necessary as it didn't cause any misbehaviour when running the software.
Thus the benefit of having a specific test for this case isn't really there.

@doodzik doodzik merged commit 4b7458b into master Jul 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.