New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush `OrderReporter` before running test #89

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@DazWorrall
Member

DazWorrall commented Oct 1, 2018

Small change so we can always trust that, while running, the value in the logs is up to date.

@DazWorrall DazWorrall requested a review from casperisfine Oct 1, 2018

@casperisfine

LGTM. Alternatively (or additionally) we could change the proctitle to make it easy to see what test is being processed.

@DazWorrall

This comment has been minimized.

Show comment
Hide comment
@DazWorrall

DazWorrall Oct 1, 2018

Member

we could change the proctitle to make it easy to see what test is being processed.

Nice idea, those can be easily truncated through layers of docker/ssh/etc though.

Member

DazWorrall commented Oct 1, 2018

we could change the proctitle to make it easy to see what test is being processed.

Nice idea, those can be easily truncated through layers of docker/ssh/etc though.

@DazWorrall DazWorrall merged commit 8fbaca8 into master Oct 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@DazWorrall DazWorrall deleted the flush-test-order branch Oct 1, 2018

@shopify-shipit shopify-shipit bot deployed to rubygems Oct 1, 2018 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment