Add favicon to theme settings (#86)

Chris Berthe · web-flow · commit a38c7780e546 · 2021-07-05T13:25:37.000-04:00
diff --git a/config/settings_schema.json b/config/settings_schema.json
@@ -250,5 +250,16 @@
         "info": "t:settings_schema.social-media.settings.social_vimeo_link.info"
       }
     ]
+  },
+  {
+    "name": "t:settings_schema.favicon.name",
+    "settings": [
+      {
+        "type": "image_picker",
+        "id": "favicon",
+        "label": "t:settings_schema.favicon.settings.favicon.label",
+        "info": "t:settings_schema.favicon.settings.favicon.info"
+      }
+    ]
   }
 ]
diff --git a/layout/password.liquid b/layout/password.liquid
@@ -8,6 +8,10 @@
     <link rel="canonical" href="{{ canonical_url }}">
     <link rel="preconnect" href="https://cdn.shopify.com" crossorigin>
 
+    {%- if settings.favicon != blank -%}
+      <link rel="icon" type="image/png" href="{{ settings.favicon | img_url: '32x32' }}">
+    {%- endif -%}
+
     {%- unless settings.type_header_font.system? -%}
       <link rel="preconnect" href="https://fonts.shopifycdn.com" crossorigin>
     {%- endunless -%}
diff --git a/layout/theme.liquid b/layout/theme.liquid
@@ -8,6 +8,10 @@
     <link rel="canonical" href="{{ canonical_url }}">
     <link rel="preconnect" href="https://cdn.shopify.com" crossorigin>
 
+    {%- if settings.favicon != blank -%}
+      <link rel="icon" type="image/png" href="{{ settings.favicon | img_url: '32x32' }}">
+    {%- endif -%}
+
     {%- unless settings.type_header_font.system? -%}
       <link rel="preconnect" href="https://fonts.shopifycdn.com" crossorigin>
     {%- endunless -%}
diff --git a/locales/en.default.schema.json b/locales/en.default.schema.json
@@ -157,6 +157,15 @@
           "info": "https://vimeo.com/shopify"
         }
       }
+    },
+    "favicon": {
+      "name": "Favicon",
+      "settings": {
+        "favicon": {
+          "label": "Favicon image",
+          "info": "Will be scaled down to 32 x 32px"
+        }
+      }
     }
   },
   "sections": {
diff --git a/templates/gift_card.liquid b/templates/gift_card.liquid
@@ -11,6 +11,10 @@
     <link rel="canonical" href="{{ canonical_url }}">
     <link rel="preconnect" href="https://cdn.shopify.com" crossorigin>
 
+    {%- if settings.favicon != blank -%}
+      <link rel="icon" type="image/png" href="{{ settings.favicon | img_url: '32x32' }}">
+    {%- endif -%}
+
     {%- unless settings.type_header_font.system? -%}
       <link rel="preconnect" href="https://fonts.shopifycdn.com" crossorigin>
     {%- endunless -%}

Original file line number	Diff line number	Diff line change
`@@ -250,5 +250,16 @@`
`250`	`250`	`"info": "t:settings_schema.social-media.settings.social_vimeo_link.info"`
`251`	`251`	`}`
`252`	`252`	`]`
	`253`	`+ },`
	`254`	`+ {`
	`255`	`+ "name": "t:settings_schema.favicon.name",`
	`256`	`+ "settings": [`
	`257`	`+ {`
	`258`	`+ "type": "image_picker",`
	`259`	`+ "id": "favicon",`
	`260`	`+ "label": "t:settings_schema.favicon.settings.favicon.label",`
	`261`	`+ "info": "t:settings_schema.favicon.settings.favicon.info"`
	`262`	`+ }`
	`263`	`+ ]`
`253`	`264`	`}`
`254`	`265`	`]`
Original file line number	Diff line number	Diff line change
`@@ -157,6 +157,15 @@`
`157`	`157`	`"info": "https://vimeo.com/shopify"`
`158`	`158`	`}`
`159`	`159`	`}`
	`160`	`+ },`
	`161`	`+ "favicon": {`
	`162`	`+ "name": "Favicon",`
	`163`	`+ "settings": {`
	`164`	`+ "favicon": {`
	`165`	`+ "label": "Favicon image",`
	`166`	`+ "info": "Will be scaled down to 32 x 32px"`
	`167`	`+ }`
	`168`	`+ }`
`160`	`169`	`}`
`161`	`170`	`},`
`162`	`171`	`"sections": {`