From cd888ec5ae5a0677aff7cd41962f5a44f155184e Mon Sep 17 00:00:00 2001 From: Fran Dios Date: Tue, 28 May 2024 11:22:07 +0900 Subject: [PATCH] Invalidate entry point on change in dev server (#2153) * Fix entry point invalidation on change * Changesets --- .changeset/purple-carrots-melt.md | 5 +++++ packages/mini-oxygen/src/vite/worker-entry.ts | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changeset/purple-carrots-melt.md diff --git a/.changeset/purple-carrots-melt.md b/.changeset/purple-carrots-melt.md new file mode 100644 index 0000000000..7299ea4d47 --- /dev/null +++ b/.changeset/purple-carrots-melt.md @@ -0,0 +1,5 @@ +--- +'@shopify/mini-oxygen': patch +--- + +Update server in development when entry point (`/server.js`) changes. diff --git a/packages/mini-oxygen/src/vite/worker-entry.ts b/packages/mini-oxygen/src/vite/worker-entry.ts index aa808ab97a..d3dcc622e5 100644 --- a/packages/mini-oxygen/src/vite/worker-entry.ts +++ b/packages/mini-oxygen/src/vite/worker-entry.ts @@ -108,7 +108,8 @@ function fetchEntryModule(publicUrl: URL, env: ViteEnv) { // module to avoid hanging promises in workerd for (const update of data.updates) { runtime.moduleCache.invalidateDepTree([ - update.path, + // Module IDs are absolute from root + update.path.replace(/^\.\//, '/'), ...(update.ssrInvalidates ?? []), ]); }