From 066138b1e13175dcf3f209d07e36528f9a02e2b1 Mon Sep 17 00:00:00 2001 From: Max Laverse Date: Mon, 18 Dec 2017 21:43:09 +0100 Subject: [PATCH] Fix requires_endpoints? condition --- lib/kubernetes-deploy/kubernetes_resource/service.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/kubernetes-deploy/kubernetes_resource/service.rb b/lib/kubernetes-deploy/kubernetes_resource/service.rb index cdb3ca4ef..794861e78 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/service.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/service.rb @@ -48,7 +48,12 @@ def exposes_zero_replica_deployment? end def requires_endpoints? - return false if external_name_svc? || @related_deployment_replicas.blank? + # Service of type External don't have endpoints + return false if external_name_svc? + + # problem counting replicas - by default, assume endpoints are required + return true if @related_deployment_replicas.blank? + @related_deployment_replicas > 0 end