diff --git a/CHANGELOG.md b/CHANGELOG.md index ae5a159f1..d4b297870 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ *Bug fixes* - Attempting to deploy from a directory that only contains `secrets.ejson` will no longer fail deploy ([#416](https://github.com/Shopify/kubernetes-deploy/pull/416)) +- Resources which don't exist will be reported as "Not Found" rather than "Unknown" *Other* - Update kubeclient gem to 4.2.2. Note this replaces the `KubeclientBuilder::GoogleFriendlyConfig` class with `KubeclientBuilder::KubeConfig` ([#418](https://github.com/Shopify/kubernetes-deploy/pull/418)) diff --git a/lib/kubernetes-deploy/kubernetes_resource.rb b/lib/kubernetes-deploy/kubernetes_resource.rb index 3bb7dbead..b3550be39 100644 --- a/lib/kubernetes-deploy/kubernetes_resource.rb +++ b/lib/kubernetes-deploy/kubernetes_resource.rb @@ -179,7 +179,7 @@ def observed_generation end def status - exists? ? "Exists" : "Unknown" + exists? ? "Exists" : "Not Found" end def type diff --git a/lib/kubernetes-deploy/kubernetes_resource/config_map.rb b/lib/kubernetes-deploy/kubernetes_resource/config_map.rb index 8aabec341..5fa8cccde 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/config_map.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/config_map.rb @@ -8,7 +8,7 @@ def deploy_succeeded? end def status - exists? ? "Available" : "Unknown" + exists? ? "Available" : "Not Found" end def deploy_failed? diff --git a/lib/kubernetes-deploy/kubernetes_resource/ingress.rb b/lib/kubernetes-deploy/kubernetes_resource/ingress.rb index 7cf9d2d83..272795aed 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/ingress.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/ingress.rb @@ -4,7 +4,7 @@ class Ingress < KubernetesResource TIMEOUT = 30.seconds def status - exists? ? "Created" : "Unknown" + exists? ? "Created" : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/persistent_volume_claim.rb b/lib/kubernetes-deploy/kubernetes_resource/persistent_volume_claim.rb index 9593f3b9b..2ea63753d 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/persistent_volume_claim.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/persistent_volume_claim.rb @@ -4,7 +4,7 @@ class PersistentVolumeClaim < KubernetesResource TIMEOUT = 5.minutes def status - exists? ? @instance_data["status"]["phase"] : "Unknown" + exists? ? @instance_data["status"]["phase"] : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/pod_disruption_budget.rb b/lib/kubernetes-deploy/kubernetes_resource/pod_disruption_budget.rb index 83630007b..32e4d9716 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/pod_disruption_budget.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/pod_disruption_budget.rb @@ -4,7 +4,7 @@ class PodDisruptionBudget < KubernetesResource TIMEOUT = 10.seconds def status - exists? ? "Available" : "Unknown" + exists? ? "Available" : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/pod_template.rb b/lib/kubernetes-deploy/kubernetes_resource/pod_template.rb index 9cf5c9750..40e0c771b 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/pod_template.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/pod_template.rb @@ -2,7 +2,7 @@ module KubernetesDeploy class PodTemplate < KubernetesResource def status - exists? ? "Available" : "Unknown" + exists? ? "Available" : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/resource_quota.rb b/lib/kubernetes-deploy/kubernetes_resource/resource_quota.rb index d8aebb5c8..e987d2094 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/resource_quota.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/resource_quota.rb @@ -4,7 +4,7 @@ class ResourceQuota < KubernetesResource TIMEOUT = 30.seconds def status - exists? ? "In effect" : "Unknown" + exists? ? "In effect" : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/role.rb b/lib/kubernetes-deploy/kubernetes_resource/role.rb index 1f900d1b2..acb36cef1 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/role.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/role.rb @@ -4,7 +4,7 @@ class Role < KubernetesResource TIMEOUT = 30.seconds def status - exists? ? "Created" : "Unknown" + exists? ? "Created" : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/role_binding.rb b/lib/kubernetes-deploy/kubernetes_resource/role_binding.rb index bcd1c9d06..d6e093a62 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/role_binding.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/role_binding.rb @@ -4,7 +4,7 @@ class RoleBinding < KubernetesResource TIMEOUT = 30.seconds def status - exists? ? "Created" : "Unknown" + exists? ? "Created" : "Not Found" end def deploy_succeeded? diff --git a/lib/kubernetes-deploy/kubernetes_resource/service_account.rb b/lib/kubernetes-deploy/kubernetes_resource/service_account.rb index 2b4548afa..359bf80b0 100644 --- a/lib/kubernetes-deploy/kubernetes_resource/service_account.rb +++ b/lib/kubernetes-deploy/kubernetes_resource/service_account.rb @@ -4,7 +4,7 @@ class ServiceAccount < KubernetesResource TIMEOUT = 30.seconds def status - exists? ? "Created" : "Unknown" + exists? ? "Created" : "Not Found" end def deploy_succeeded?