From 486ab60984b8eadbb69ae7278304ece75116c1da Mon Sep 17 00:00:00 2001 From: Stefan Kaes Date: Sun, 10 Dec 2017 11:22:14 +0100 Subject: [PATCH] make sure current_sha in fixtures is always a string If you con't don this, the kubernetes server will complain in the following way: Error from server (BadRequest): error when creating "/var/folders/rf/.../T/Deployment-web-one20171210-42930-1xcb15.yml": Deployment in version "v1beta1" cannot be handled as a Deployment: [pos 999]: json: expect char '"' but got char '7' --- test/fixtures/collection-with-erb/web_collection.yml.erb | 2 +- test/fixtures/hello-cloud/web.yml.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/fixtures/collection-with-erb/web_collection.yml.erb b/test/fixtures/collection-with-erb/web_collection.yml.erb index 807eb83fd..d28575ee7 100644 --- a/test/fixtures/collection-with-erb/web_collection.yml.erb +++ b/test/fixtures/collection-with-erb/web_collection.yml.erb @@ -21,6 +21,6 @@ spec: name: http env: - name: GITHUB_REV - value: <%= current_sha %> + value: "<%= current_sha %>" --- <% end %> diff --git a/test/fixtures/hello-cloud/web.yml.erb b/test/fixtures/hello-cloud/web.yml.erb index f1f6087c7..b91771176 100644 --- a/test/fixtures/hello-cloud/web.yml.erb +++ b/test/fixtures/hello-cloud/web.yml.erb @@ -55,7 +55,7 @@ spec: name: http env: - name: GITHUB_REV - value: <%= current_sha %> + value: "<%= current_sha %>" - name: CONFIG valueFrom: configMapKeyRef: