Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): add rules description #309

Merged
merged 2 commits into from Oct 2, 2020
Merged

chore(docs): add rules description #309

merged 2 commits into from Oct 2, 2020

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Oct 2, 2020

Description

These where the only rule description missing.

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

genevieveluyt
genevieveluyt reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@genevieveluyt genevieveluyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aslafy-z, Thank you for your contribution! Just one small change please

auditors/image/image.go Outdated Show resolved Hide resolved
@aslafy-z @genevieveluyt
Update auditors/image/image.go
bfbeffb 
Co-authored-by: Genevieve Luyt <11131143+genevieveluyt@users.noreply.github.com>
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Oct 2, 2020

Just applied it!

genevieveluyt
genevieveluyt approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@genevieveluyt genevieveluyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@genevieveluyt genevieveluyt merged commit 7d46836 into Shopify:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevieveluyt genevieveluyt genevieveluyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslafy-z @genevieveluyt