Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog #445

Merged
merged 3 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@KnVerey
Copy link
Member

KnVerey commented Mar 7, 2019

What are you trying to accomplish with this PR?

Correct a caveat in the changelog that turned out to be wrong. The EjsonSecretProvisioner used apply all along, so removing a secret in the first deploy using the new version will work as expected.

out, err, st = @kubectl.run("apply", "--filename=#{file.path}")

Also be more helpful by suggesting how to check for affected secrets and how to unannotate them.

@Shopify/cloudx

KnVerey added some commits Mar 7, 2019

@KnVerey KnVerey requested review from DazWorrall and dturn Mar 7, 2019

@dturn

dturn approved these changes Mar 7, 2019

@@ -10,10 +10,10 @@

*Features*

- **[Breaking change]** Support for deploying Secrets from templates ([#424](https://github.com/Shopify/kubernetes-deploy/pull/424)).
* If you previously used this gem to deploy secrets from EJSON and the first time commit you deploy using this version removes one or more of them, they will not be pruned.
- **[Breaking change]** Support for deploying Secrets from templates ([#424](https://github.com/Shopify/kubernetes-deploy/pull/424)). Because non-ejson secrets are now fully supported and therefore **subject to pruning like any other resource**:

This comment has been minimized.

@dturn

dturn Mar 7, 2019

Contributor

Because Non-ejson secrets ...

@DazWorrall
Copy link
Member

DazWorrall left a comment

:shipit:

@KnVerey KnVerey merged commit 3d5c45c into master Mar 8, 2019

2 checks passed

buildkite/kubernetes-deploy-gem Build #1513 passed (8 minutes, 39 seconds)
Details
codecov/patch Coverage not affected when comparing 97e81c3...4d6c3cf
Details

@KnVerey KnVerey deleted the fix_changelog branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.