Permalink
Browse files

Clarified compatibility comments, removed unused var from tag test.

  • Loading branch information...
1 parent 2b04590 commit 58ad90677b7c3d76b6e9a1aaa4f4306b97754433 @kristianpd kristianpd committed Jan 20, 2012
Showing with 2 additions and 3 deletions.
  1. +2 −2 lib/liquid/tags/for.rb
  2. +0 −1 test/liquid/tags/for_tag_test.rb
@@ -75,7 +75,7 @@ def render(context)
collection = context[@collection_name]
collection = collection.to_a if collection.is_a?(Range)
- # 1.8.7 compatibility
+ # Maintains Ruby 1.8.7 String#each behaviour on 1.9
return render_else(context) unless collection.respond_to?(:each) or collection.is_a?(String)
from = if @attributes['offset'] == 'continue'
@@ -125,7 +125,7 @@ def slice_collection_using_each(collection, from, to)
index = 0
yielded = 0
- # 1.8.7 compatibility
+ # Maintains Ruby 1.8.7 String#each behaviour on 1.9
return [collection] if collection.is_a?(String)
collection.each do |item|
@@ -182,7 +182,6 @@ def test_for_tag_string
'{%for val in string limit:1%}{{val}}{%endfor%}',
'string' => "test string")
- fields = %w(name length index index0 rindex rindex0 first last)
assert_template_result('val-string-1-1-0-1-0-true-true-test string',
'{%for val in string%}' +
'{{forloop.name}}-' +

0 comments on commit 58ad906

Please sign in to comment.