Add Liquid::ParseContext#parse_expression for liquid-c node disabling #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to be able to disable liquid-c VM rendering at runtime, but right now expresion parsing is done using Expression.parse, which isn't aware of the parse context. That prevents us from conditionally compiling to VM code based on a parse option.
macournoyer
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Does this affect profiling too? I guess it's in preparation for Shopify/liquid-c#96.
|
No, this shouldn't affect profiling. Although, it might help better test that path. It isn't a blocker for Shopify/liquid-c#96. I've added a comment to that PR (Shopify/liquid-c#96 (comment)) to explain why I haven't merged it yet. |
peterzhu2118
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We would like to be able to measure the performance benefit of liquid VM rendering in production by disabling liquid VM compilation at runtime. However, tags are parsing expressions with
Liquid::Expression.parse, which doesn't give liquid-c access to the parse context in order to determine whether liquid VM compilation is enabled or not.Solution
Add
Liquid::ParseContext#parse_expressionand use it in the liquid tags to parse expressions.