Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make if less dangerous #273

Merged
merged 3 commits into from
Oct 28, 2013
Merged

Make if less dangerous #273

merged 3 commits into from
Oct 28, 2013

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Oct 28, 2013

This removes an unnecessary to_sym and prevents calling of Kernel methods

@fw42 @dylanahsmith

@fw42
Copy link
Contributor

fw42 commented Oct 28, 2013

Ruby 1.8 doesn't have public_send... Why do the tests not fail? Anyhow.. We can still get this into Shopify, just not the 2.6 branch of Liquid, but we are pretty much done with that anyways. cc @arthurnn

@fw42
Copy link
Contributor

fw42 commented Oct 28, 2013

👍 on the actual change

@fw42
Copy link
Contributor

fw42 commented Oct 28, 2013

Ah I think we removed 1.8 from Travis on master

@fw42
Copy link
Contributor

fw42 commented Oct 28, 2013

Please add a comment to History.md before merging

bouk added a commit that referenced this pull request Oct 28, 2013
@bouk bouk merged commit 71a386f into master Oct 28, 2013
@bouk bouk deleted the make-if-less-dangerous branch October 28, 2013 13:39
@arthurnn
Copy link
Contributor

❤️

@parkr
Copy link
Contributor

parkr commented Oct 28, 2013

Does this require Ruby > 1.9?

@dylanahsmith
Copy link
Contributor

Yes, but pull #274 should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants