New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace control character and associated tests #773

Merged
merged 2 commits into from Aug 11, 2016

Conversation

Projects
None yet
6 participants
@evulse
Contributor

evulse commented Jun 27, 2016

This adds support for {{- and {%- syntax which will lstrip! and -}} and -%} which will rstrip!

Depends on Shopify/liquid-c#30 to pass all tests.

Resolve issues #216, #215, #214, #194, #171, #162

Previously Pull Request #746

@evulse

This comment has been minimized.

Show comment
Hide comment
@evulse

evulse Jun 27, 2016

Contributor

@fw42 was easier to regenerate pull request on new fork

Contributor

evulse commented Jun 27, 2016

@fw42 was easier to regenerate pull request on new fork

Show outdated Hide outdated lib/liquid/block_body.rb Outdated
@dylanahsmith

This comment has been minimized.

Show comment
Hide comment
@dylanahsmith
Member

dylanahsmith commented Jul 12, 2016

LGTM

@fw42

This comment has been minimized.

Show comment
Hide comment
@fw42

fw42 Aug 5, 2016

Member

The test fails here are because the change in liquid-c isn't merged yet, right?

Member

fw42 commented Aug 5, 2016

The test fails here are because the change in liquid-c isn't merged yet, right?

@evulse

This comment has been minimized.

Show comment
Hide comment
@evulse

evulse Aug 5, 2016

Contributor

Yes as soon as this is pointed to the new liquid-c commit these pass as expected. Also the liquid-c version passes with this commit included as well.

Contributor

evulse commented Aug 5, 2016

Yes as soon as this is pointed to the new liquid-c commit these pass as expected. Also the liquid-c version passes with this commit included as well.

@evulse

This comment has been minimized.

Show comment
Hide comment
@evulse

evulse Aug 6, 2016

Contributor

screen shot 2016-08-06 at 11 49 19 pm

Just using Mozilla's Nunjucks on a project and noticed it uses this same syntax. Good to see all the libraries heading in this direction.

Contributor

evulse commented Aug 6, 2016

screen shot 2016-08-06 at 11 49 19 pm

Just using Mozilla's Nunjucks on a project and noticed it uses this same syntax. Good to see all the libraries heading in this direction.

@fw42 fw42 merged commit f251856 into Shopify:master Aug 11, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@fw42 fw42 referenced this pull request Aug 11, 2016

Closed

Whitespace issues #216

@fw42

This comment has been minimized.

Show comment
Hide comment
@fw42

fw42 Aug 11, 2016

Member

Thanks for your contribution, great job!

Member

fw42 commented Aug 11, 2016

Thanks for your contribution, great job!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 11, 2016

Contributor

Liquid 4?!?!?! Could this be a thing in Liquid 4?!?!

Contributor

parkr commented Aug 11, 2016

Liquid 4?!?!?! Could this be a thing in Liquid 4?!?!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 11, 2016

Contributor

💗 🎉 🎊

Contributor

parkr commented Aug 11, 2016

💗 🎉 🎊

@fw42

This comment has been minimized.

Show comment
Hide comment
@fw42

fw42 Aug 11, 2016

Member

I don't see why not

Member

fw42 commented Aug 11, 2016

I don't see why not

@galopin

This comment has been minimized.

Show comment
Hide comment
@galopin

galopin Aug 30, 2016

@evulse @fw42 Wondering if this nifty whitespace control feature could be backported into the 3.x version ⁉️

galopin commented Aug 30, 2016

@evulse @fw42 Wondering if this nifty whitespace control feature could be backported into the 3.x version ⁉️

@pathawks pathawks referenced this pull request Oct 20, 2016

Merged

Output plugins in feed #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment