Drop support for ruby 2.0 #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll probably want to add notes for macOS users on how to upgrade Ruby since Sierra still ships with 2.0. |
|
I don't think it is generally recommended to install gems into the system ruby anyways. It can't be upgraded because parts of the system probably depend on that version. For reference, rails requires ruby version |
pushrax
approved these changes
Dec 4, 2016
fw42
approved these changes
Dec 4, 2016
It is no longer maintained upstream
Travis doesn't have a ruby 2.3 alias, so the latest 2.3.x version is specified instead.
dylanahsmith
force-pushed
the
drop-ruby-2.0
branch
from
4f27c20
to
812e3c5
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fw42 & @pushrax please review
https://www.ruby-lang.org/en/downloads/ says ruby 2.0 is no longer maintained, so I don't think we should support it for liquid v4.
Motivation
ruby 2.1 added Exception#cause which I would like to assume it available for a PR I'm going to open up to add a Liquid::InternalError that will wrap non-Liquid::Error exceptions. This way we can attach the template_name and line_number to the error and still have the original exception available through the cause method for error reporting and logging.