-
Notifications
You must be signed in to change notification settings - Fork 71
upgrade dependencies #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
omniauth-shopify-oauth2.gemspec
Outdated
| s.add_runtime_dependency 'omniauth-oauth2', '~> 1.2' | ||
| s.add_runtime_dependency 'oauth2', '~> 1.1.0' | ||
| s.add_runtime_dependency 'omniauth-oauth2', '~> 1.4.0' | ||
| s.add_runtime_dependency 'oauth2', '~> 1.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this dependency, we can let omniauth-oauth2 resolve it. It was added only because v1.2.0 of oauth2 introduced an issue on encoding which was later fixed by ruby-oauth/oauth2#271
8b82cdc to
8b3da0c
Compare
|
|
||
| s.add_runtime_dependency 'omniauth-oauth2', '~> 1.2' | ||
| s.add_runtime_dependency 'oauth2', '~> 1.1.0' | ||
| s.add_runtime_dependency 'omniauth-oauth2', '~> 1.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omniauth/omniauth-oauth2@v1.2.0...v1.4.0
The change from 1.2.0 to 1.4.0 looks safe to me but we might need to loose ruby 2.1 support. Not sure how many app which are on 2.1 still uses that gem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to lock this version to depend on 2.1.9 and greater, mirroring omniauth gem's requirements https://rubygems.org/gems/omniauth
8b3da0c to
caf02c2
Compare
|
i think travis ruby versions may need to be updated to test ruby |
Edouard-chin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's modify travis rvm and should be good
https://github.com/Shopify/omniauth-shopify-oauth2/blob/master/.travis.yml#L3
be27f01 to
027e09a
Compare
|
updated, thanks for the feedback! |
JoePym
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the plan to bump the version of the gem? I feel given as we are deprecating support for a patch ruby version, we should bump the patch level of the gem.
|
@JoePym we should do a major bump i think, since it's a breaking backwards incompatible change with certain ruby versions? |
027e09a to
ecf4b5b
Compare
|
we will do a minor version bump for this as per discussion |
Need to upgrade dependencies for this gem, or else there will be a gem conflict with other public gems, e.g., latest google-cloud-storage requires faraday ~> 0.11 in it's chain of dependencies:
Issue: 622a19a Looks to have been resolved by ruby-oauth/oauth2#271 so we can remove the restriction on oauth2 dependency lock