Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme issue in android chrome #586

Merged
merged 6 commits into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@HYPD
Copy link
Contributor

commented Jun 5, 2019

Fixes #382

@kaelig

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Yay!

Screenshot_20190605-134045

@kaelig

kaelig approved these changes Jun 5, 2019

@kaelig

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Note that when added to homescreen, the color still appears:

Screenshot_20190605-134405

name: `gatsby-starter-default`,
short_name: `starter`,
name: `Polaris icons`,
short_name: `Polaris icons`,

This comment has been minimized.

Copy link
@kaelig

kaelig Jun 5, 2019

Member

Good catch

@AndrewMusgrave

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

display: 'standalone' is needed to add this to home screens cc/ @kaelig

mobile-ui : "This mode is similar to fullscreen, but provides the user with some means to access a minimal set of UI elements for controlling navigation (i.e., back, forward, reload, etc).
Note: Only supported by Chrome on mobile."

@HYPD

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@kaelig can you confirm it's still appearing? It should be fixed

@kaelig kaelig temporarily deployed to polaris-icons-pr-586 Jun 5, 2019 Inactive

@kaelig

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

These theme values aren't required as per the web manifest spec, why do we set them at all?

@kaelig kaelig temporarily deployed to polaris-icons-pr-586 Jun 5, 2019 Inactive

@kaelig kaelig temporarily deployed to polaris-icons-pr-586 Jun 5, 2019 Inactive

@HYPD

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

I removed the values, could you please check again if the theme comes up on the home screen?

@kaelig

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Yep, the theme colors were removed!

@kaelig kaelig merged commit 0e5f703 into master Jun 5, 2019

6 checks passed

WIP ready for review
Details
buildkite/polaris-icons Build #1511 passed (2 minutes, 19 seconds)
Details
buildkite/polaris-icons-production-builder Build #1249 passed (3 minutes, 27 seconds)
Details
buildkite/shopify-polaris-icons-binary-authorization-validator Build #1173 passed (18 seconds)
Details
buildkite/shopify-polaris-icons-k8s-template-validator Build #1236 passed (19 seconds)
Details
changelog changelog entry not needed
Details

@kaelig kaelig deleted the theme-fix branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.