New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Loading] Use Loading outside of Frame #997
Comments
Hi @jim-chou-shopify! Is the loading component here meant to indicate that the whole page is updating, or just a section? If it's not the whole page, the spinner component might be a better choice (and doesn't require the use of the frame component). The loading component is typically meant to convey that a whole page is loading or a page-level activity is taking place, not just a section of the page. |
Hi @dpersing, |
Our thinking was that using this would be more effective than a spinner because: |
Thanks for the extra context, @jim-chou-shopify and @supervee! @ry5n Do you have thoughts on this? |
I don鈥檛 have strong feelings on this. I like the idea of emphasizing the content is from an external source, but I鈥檓 not sure the loading bar is enough for people to understand that. @alyseadlard has done a lot of thinking about loading states, I wonder if she鈥檇 have some thoughts on the experience. Making this available outside of the frame might take some doing. @tmlayton may have thoughts on the engineering as well as the user experience. |
@ry5n I agree that ux may need further discussions, but I feel the engineering aspect is straightforward by exporting |
Hey all, just a couple questions:
I'm not sure I understand the rationale here. Wouldn't use of I might need some help understanding what |
The use case is to show a loading bar for preview section when fetching app generated url. |
Cool, can I get some screenshots? Not sure what "Preview section" means. |
A gif of the preview section is under Rationale section of the issue and it's a Card. |
Is this a card or is it a modal? Sorry, I need a bit more context. |
There is also a link to the PR for our use case . |
From a UX POV, |
Yes it's part of the page. |
I'd suggest using |
Just for some added information... Another reason the spinner can be a bit weird is that the preview refreshes based on the merchants interaction with the form. This isn't the best example because we've done some improvements around what event triggers the refresh, but here's a gif of typing with the spinner to refresh the preview: There's also an overlay in this gif but the point being, a spinner coming in and out would still be a big UI change that would feel jarring. With the loading bar, it's less intrusive and the merchant would be able to see the previous preview while continuing to edit the form. |
Gotcha, thanks for the clarity @supervee @macdonaldr93! I see what you mean about both skeleton being too unpredictable and spinner being too disruptive. If it's not too much work (@tmlayton would know), let's make |
FYI, we are trying to expose Frame/components/Loading component to be used outside of |
Hey everyone, sorry I missed this! What did you end up going with in the marketing section?
My initial reaction on the UX is it sounds reasonable, but not enough that I would immediately commit to doing the work in Polaris. Can we use your work in the marketing section as exploration around a section-specific loading bar? I would recommend building the component out in web in the polaris-next sub package: https://github.com/Shopify/web/tree/master/packages/%40shopify/polaris-next. The engineering effort for this should be minimal. |
Hi @tmlayton, |
Looks really nice! Is this something you would have the time to contribute to Polaris? |
Ya for sure. I can create a PR to Polaris with the loader. |
This issue has been inactive for 180 days and labeled with |
Feature request summary
Expose Loading component to be used outside of
Frame
.Rationale
Marketing section has a use case to use
Loading
component to indicate a section of the page is loading.@supervee
馃専 Feature requests that are not yet planned will be closed. We then use the issue鈥檚 馃憤 upvotes to track and set priorities. See the contribution guidelines for more information.
The text was updated successfully, but these errors were encountered: