Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash replace #1012

Merged
merged 3 commits into from Feb 26, 2019

Conversation

@AndrewMusgrave
Copy link
Member

commented Feb 11, 2019

WHY are these changes introduced?

Part of removing lodash #991

WHAT is this pull request doing?

Replacing lodash replace with native string replace

How to 馃帺

Test pass? 馃挴

TODO:

  • add changelog

@BPScott BPScott temporarily deployed to polaris-react-pr-1012 Feb 11, 2019 Inactive

@AndrewMusgrave AndrewMusgrave referenced this pull request Feb 11, 2019
9 of 11 tasks complete
@solonaarmstrong
Copy link
Contributor

left a comment

Obviously shrink ray needs to rerun, but otherwise 馃憣

@@ -20,7 +19,7 @@ export default function translate(
}

if (replacements) {
return replace(text, REPLACE_REGEX, (match: string) => {
return text.replace(REPLACE_REGEX, (match: string) => {
const replacement: string = match.substring(1, match.length - 1);

This comment has been minimized.

Copy link
@elizabethletourneau

elizabethletourneau Feb 13, 2019

Contributor

馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣 馃憣

@AndrewMusgrave AndrewMusgrave force-pushed the rm-lodash-replace branch from 226b90f to 2853e66 Feb 26, 2019

@BPScott BPScott temporarily deployed to polaris-react-pr-1012 Feb 26, 2019 Inactive

@AndrewMusgrave AndrewMusgrave merged commit 4ca9b07 into master Feb 26, 2019

8 checks passed

CLA Contributor License Agreement (CLA) status
Details
WIP ready for review
Details
changelog changelog entry included
Details
ci/circleci: check Your tests passed on CircleCI!
Details
ci/circleci: percy Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90%)
Details
percy/polaris-react Visual review automatically approved, no visual changes found.
Details
shrink-ray Webpack build report complete :)
Details

@AndrewMusgrave AndrewMusgrave deleted the rm-lodash-replace branch Feb 26, 2019

@amrocha amrocha deployed to production Mar 7, 2019 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.