From 4d0ddc0887bd025513eb29011b0c6eacf95228bf Mon Sep 17 00:00:00 2001 From: Devon Persing Date: Tue, 26 Feb 2019 09:48:14 -0800 Subject: [PATCH 1/2] Fix for ariaPressed documentation --- UNRELEASED.md | 1 + src/components/Button/README.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/UNRELEASED.md b/UNRELEASED.md index 301b4213aab..80684c88e6b 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -20,6 +20,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f - Made documentation for properties only available in a stand-alone context more explicit for `Modal` ([#1065] https://github.com/Shopify/polaris-react/pull/1065) - Added accessibility documentation for `Loading`([#1075](https://github.com/Shopify/polaris-react/pull/1075)) +- Fixes documentation about the `ariaPressed` prop for `Button` ([...](...)) ### Development workflow diff --git a/src/components/Button/README.md b/src/components/Button/README.md index 44022b94d5e..f18702a600b 100644 --- a/src/components/Button/README.md +++ b/src/components/Button/README.md @@ -319,7 +319,7 @@ Buttons can have different states that are visually and programmatically conveye - Use the `ariaControls` prop to add an `aria-controls` attribute to the button. Use the attribute to point to the unique `id` of the content that the button manages. - If a button expands or collapses adjacent content, then use the `ariaExpanded` prop to add the `aria-expanded` attribute to the button. Set the value to convey the current expanded (`true`) or collapsed (`false`) state of the content. - Use the `disabled` prop to set the `disabled` state of the button. This prevents merchants from being able to interact with the button, and conveys its inactive state to assistive technologies. -- Use the `pressed` prop to add an `aria-pressed` attribute and enable a pressed style to the button. +- Use the `ariaPressed` prop to add an `aria-pressed` attribute to the button. #### Navigation From 6e3dd4a95ab91bb481434f1b2c1cfc7d9f884e95 Mon Sep 17 00:00:00 2001 From: Devon Persing Date: Tue, 26 Feb 2019 09:50:45 -0800 Subject: [PATCH 2/2] Added PR # --- UNRELEASED.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UNRELEASED.md b/UNRELEASED.md index 80684c88e6b..7f0a13e3384 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -20,7 +20,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f - Made documentation for properties only available in a stand-alone context more explicit for `Modal` ([#1065] https://github.com/Shopify/polaris-react/pull/1065) - Added accessibility documentation for `Loading`([#1075](https://github.com/Shopify/polaris-react/pull/1075)) -- Fixes documentation about the `ariaPressed` prop for `Button` ([...](...)) +- Fixes documentation about the `ariaPressed` prop for `Button` ([#1097](https://github.com/Shopify/polaris-react/pull/1097)) ### Development workflow