[IndexTable] Fix header tooltip styling #11066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @laurkim! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/polaris@0.0.0-snapshot-release-20231031125108 |
laurkim
added
the
Bug
aaronccasanova
approved these changes
Oct 31, 2023
Merged
sophschneider
pushed a commit
that referenced
this pull request
Oct 31, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.0.3 ### Patch Changes - [#11018](#11018) [`38ed8a9ba`](38ed8a9) Thanks [@zaquille-oneil](https://github.com/zaquille-oneil)! - Fixed `TextField` blurring when interacting with the `Spinner` buttons - [#11067](#11067) [`a1cff3557`](a1cff35) Thanks [@laurkim](https://github.com/laurkim)! - Fixed disabled button styling on `ContextualSaveBar` component - [#11066](#11066) [`9d5fedbce`](9d5fedb) Thanks [@laurkim](https://github.com/laurkim)! - Fixed styling on `IndexTable` component header tooltip ## polaris.shopify.com@0.60.1 ### Patch Changes - Updated dependencies \[[`38ed8a9ba`](38ed8a9), [`a1cff3557`](a1cff35), [`9d5fedbce`](9d5fedb)]: - @shopify/polaris@12.0.3 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced?
Fixes issue reported during v12 bughunt for incorrect Tooltip styling on
IndexTable headers.
### WHAT is this pull request doing?
Fixes values passed in from `defaultHeaderTooltipProps` to use the
correct padding and border radius token values.
<details>
<summary>IndexTable Heading — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/176a0b58-88b2-4ba6-9bba-2a10819dec2f"
alt="IndexTable Heading — before">
</details>
<details>
<summary>IndexTable Heading — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/635cbef9-3fec-46a5-a65a-6fa61d77abdf"
alt="IndexTable Heading — after">
</details>
### How to 🎩
[Storybook](https://5d559397bae39100201eedc1-noluxcicog.chromatic.com/?path=/story/all-components-indextable--with-heading-tooltips)
[Prod
storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-indextable--with-heading-tooltips)
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
### 🎩 checklist
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.0.3 ### Patch Changes - [Shopify#11018](Shopify#11018) [`38ed8a9ba`](Shopify@947fba6) Thanks [@zaquille-oneil](https://github.com/zaquille-oneil)! - Fixed `TextField` blurring when interacting with the `Spinner` buttons - [Shopify#11067](Shopify#11067) [`a1cff3557`](Shopify@71ff008) Thanks [@laurkim](https://github.com/laurkim)! - Fixed disabled button styling on `ContextualSaveBar` component - [Shopify#11066](Shopify#11066) [`9d5fedbce`](Shopify@0679052) Thanks [@laurkim](https://github.com/laurkim)! - Fixed styling on `IndexTable` component header tooltip ## polaris.shopify.com@0.60.1 ### Patch Changes - Updated dependencies \[[`38ed8a9ba`](Shopify@947fba6), [`a1cff3557`](Shopify@71ff008), [`9d5fedbce`](Shopify@0679052)]: - @shopify/polaris@12.0.3 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes issue reported during v12 bughunt for incorrect Tooltip styling on IndexTable headers.
WHAT is this pull request doing?
Fixes values passed in from
defaultHeaderTooltipPropsto use the correct padding and border radius token values.IndexTable Heading — before
IndexTable Heading — after
How to 🎩
Storybook
Prod storybook
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes