From 5175bcf191860fe71ee3934dee5a6321e2648cfe Mon Sep 17 00:00:00 2001 From: Marc Thomas Date: Thu, 23 Nov 2023 10:18:17 +0000 Subject: [PATCH 1/3] chore: update pagination height --- polaris-react/src/components/Pagination/Pagination.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/polaris-react/src/components/Pagination/Pagination.scss b/polaris-react/src/components/Pagination/Pagination.scss index 24bf2ddc023..b91a053d2b8 100644 --- a/polaris-react/src/components/Pagination/Pagination.scss +++ b/polaris-react/src/components/Pagination/Pagination.scss @@ -27,7 +27,7 @@ border-top: 1px solid var(--p-color-border); button { - --button-min-height: var(--p-space-600); + --button-min-height: 28px; background-color: var(--p-color-bg-surface-secondary); min-height: var(--button-min-height); min-width: var(--button-min-height); From 28990373697f9a682e8902f241859cdb80637218 Mon Sep 17 00:00:00 2001 From: Marc Thomas Date: Thu, 23 Nov 2023 10:23:54 +0000 Subject: [PATCH 2/3] chore: changest --- .changeset/strange-rats-shake.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strange-rats-shake.md diff --git a/.changeset/strange-rats-shake.md b/.changeset/strange-rats-shake.md new file mode 100644 index 00000000000..998004fe73e --- /dev/null +++ b/.changeset/strange-rats-shake.md @@ -0,0 +1,5 @@ +--- +'@shopify/polaris': minor +--- + +Updated Pagination to be correct height of 40px when in the table variant From cc5df17c6cba37e451b2d0f01b26f2fe50075e40 Mon Sep 17 00:00:00 2001 From: Marc Thomas Date: Fri, 24 Nov 2023 08:59:29 +0000 Subject: [PATCH 3/3] chore: use height token --- polaris-react/src/components/Pagination/Pagination.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/polaris-react/src/components/Pagination/Pagination.scss b/polaris-react/src/components/Pagination/Pagination.scss index b91a053d2b8..111ca99154c 100644 --- a/polaris-react/src/components/Pagination/Pagination.scss +++ b/polaris-react/src/components/Pagination/Pagination.scss @@ -27,7 +27,7 @@ border-top: 1px solid var(--p-color-border); button { - --button-min-height: 28px; + --button-min-height: var(--p-height-700); background-color: var(--p-color-bg-surface-secondary); min-height: var(--button-min-height); min-width: var(--button-min-height);