Skip to content

[ComboBox] Change tabindex prop to a negative number #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamcarchibald wants to merge 1 commit into from
Closed

[ComboBox] Change tabindex prop to a negative number #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
### Bug fixes

- Fixed `Popover` fade-in flutter on iOS by switching Transition component for CSSTransition [#1400](https://github.com/Shopify/polaris-react/pull/1400)
- Removed `tabIndex={0}` prop from `ComboBox` to allow proper tab key navigation of `Autocomplete` ([#1089](https://github.com/Shopify/polaris-react/issues/1089))

### Documentation

Expand Down
2 changes: 1 addition & 1 deletion src/components/Autocomplete/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ export default class ComboBox extends React.PureComponent<Props, State> {
emptyState && <div className={styles.EmptyState}>{emptyState}</div>;

return (
/* eslint-disable-next-line jsx-a11y/interactive-supports-focus */
<div
onClick={this.handleClick}
role="combobox"
Expand All @@ -245,7 +246,6 @@ export default class ComboBox extends React.PureComponent<Props, State> {
aria-haspopup
onFocus={this.handleFocus}
onBlur={this.handleBlur}
tabIndex={0}
>
<KeypressListener
keyCode={Key.DownArrow}
Expand Down