chore: remove nav tag from breadcrumbs #11644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
approved these changes
Feb 22, 2024
Merged
mrcthms
pushed a commit
that referenced
this pull request
Feb 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.19.0 ### Minor Changes - [#11399](#11399) [`0134d2378`](0134d23) Thanks [@sophschneider](https://github.com/sophschneider)! - Added `PositionedOverlay` scroll support for all scroll containers - [#11622](#11622) [`1f81501c8`](1f81501) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the BulkActions component to include logic to handling selecting and deselecting rows - [#11637](#11637) [`1ac638246`](1ac6382) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated Pagination table variant to have more prominent and centrally-aligned actions ### Patch Changes - [#11644](#11644) [`b95fc9807`](b95fc98) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed nav wrapper from breadcrumbs since it now only renders a single link ## polaris.shopify.com@0.63.2 ### Patch Changes - Updated dependencies \[[`0134d2378`](0134d23), [`1f81501c8`](1f81501), [`1ac638246`](1ac6382), [`b95fc9807`](b95fc98)]: - @shopify/polaris@12.19.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
This shouldn't be needed any longer since back action is singular. I don't think it's a breaking change, technically. Open to other opinions but I think it's an a11y improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be needed any longer since back action is singular. I don't think it's a breaking change, technically. Open to other opinions but I think it's an a11y improvement